Fully stop RetryableAction when cancelled #55614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently cancelling the RetryableAction does not stop one last run from being executed. This commit makes a best effort attempt to cancel a scheduled retry and guards future executions from the action already being completed.
Tim-Brooks
added
>non-issue
:Core/Infra/Resiliency
|
Pinging @elastic/es-core-infra (:Core/Infra/Resiliency) |
|
Maybe more of this work should be implemented in the |
ywelsch
reviewed
Apr 23, 2020
server/src/main/java/org/elasticsearch/action/support/RetryableAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/support/RetryableAction.java
Outdated
Show resolved
Hide resolved
Tim-Brooks
added a commit
that referenced
this pull request
Apr 28, 2020
Currently cancelling the RetryableAction does not stop one last run from being executed. This commit makes a best effort attempt to cancel a scheduled retry and guards future executions from the action already being completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently cancelling the RetryableAction does not stop one last run from
being executed. This commit makes a best effort attempt to cancel a
scheduled retry and guards future executions from the action already
being completed.