[Tests] Fix expectations around shouldPreFilterSearchShards #55522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the documentation of `pre_filter_shard_size` we state that the pre-filter phase will be executed if the request targets more than 128 shards, yet in the current test randomization we check that the TransportSearchAction.shouldPreFilterSearchShards is true already for 127 targeted shards. This should be raised to 129 instead. Closes elastic#55514
cbuescher
added
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
cbuescher
commented
Apr 21, 2020
| assertTrue(TransportSearchAction.shouldPreFilterSearchShards(clusterState, searchRequest, | ||
| indices, randomIntBetween(127, 10000))); | ||
| indices, randomIntBetween(129, 10000))); |
There was a problem hiding this comment.
I'm not exactly sure whether this should be 129 or 128, the way I read the docs I would understand them to not run pre-filter phase if <=128, but I might be wrong here. Please let me know what you think is right.
There was a problem hiding this comment.
looking at the code it would seem 129, but I would try to run the test with a static value just to be 200% sure.
There was a problem hiding this comment.
That I already did, I was just wondering what the expectations are of the code should be changed to "<=" in the appropriate place. Thanks.
cbuescher
pushed a commit
that referenced
this pull request
Apr 21, 2020
In the documentation of `pre_filter_shard_size` we state that the pre-filter phase will be executed if the request targets more than 128 shards, yet in the current test randomization we check that the TransportSearchAction.shouldPreFilterSearchShards is true already for 127 targeted shards. This should be raised to 129 instead. Closes #55514
cbuescher
pushed a commit
that referenced
this pull request
Apr 21, 2020
In the documentation of `pre_filter_shard_size` we state that the pre-filter phase will be executed if the request targets more than 128 shards, yet in the current test randomization we check that the TransportSearchAction.shouldPreFilterSearchShards is true already for 127 targeted shards. This should be raised to 129 instead. Closes #55514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation of
pre_filter_shard_sizewe state that the pre-filterphase will be executed if the request targets more than 128 shards, yet in the
current test randomization we check that the
TransportSearchAction.shouldPreFilterSearchShards is true already for 127
targeted shards. This should be raised to 129 instead.
Closes #55514