Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Provides further details on aggregations in datafeeds #55462

Merged
merged 4 commits into from
Apr 22, 2020
Merged

[DOCS] Provides further details on aggregations in datafeeds #55462

merged 4 commits into from
Apr 22, 2020

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Apr 20, 2020 •
edited
Loading

Overview

This PR contains the following changes:

  • extended footnotes emphasizing that aggs name and filed name must match
  • a new important section about field name requirements
  • removes an important label from a paragraph
  • splits the content into subsections

Preview

Aggregating data for faster performance

@szabosteve szabosteve requested a review from lcawl April 20, 2020 13:57
@szabosteve szabosteve added :ml Machine learning >docs General docs changes v7.6.3 v7.7.1 v7.8.0 v8.0.0 labels Apr 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@szabosteve szabosteve merged commit f8bfab2 into elastic:master Apr 22, 2020
@szabosteve szabosteve deleted the issue/274-mlca branch April 22, 2020 06:53
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Apr 22, 2020
@szabosteve @lcawl
[DOCS] Provides further details on aggregations in datafeeds (elastic…
0ce3406 
…#55462)

Co-authored-by: Lisa Cawley <[email protected]>
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Apr 22, 2020
@szabosteve @lcawl
[DOCS] Provides further details on aggregations in datafeeds (elastic…
381ab0f 
…#55462)

Co-authored-by: Lisa Cawley <[email protected]>
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Apr 22, 2020
@szabosteve @lcawl
[DOCS] Provides further details on aggregations in datafeeds (elastic…
62d096c 
…#55462)

Co-authored-by: Lisa Cawley <[email protected]>
@szabosteve
Copy link
Contributor Author

Backport commits:
7.x: 0ce3406
7.7: 381ab0f
7.6: 62d096c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl left review comments

Assignees
No one assigned
Labels
>docs General docs changes :ml Machine learning v7.6.3 v7.7.1 v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szabosteve @elasticmachine @lcawl @jakelandis