Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve guidance on removing default mappings. #54915

Merged
merged 3 commits into from
Apr 7, 2020

Conversation

jtibshirani
Copy link
Contributor

In 7.x, an index template will fail to apply if it contains a _default_
mapping. Several users have expressed confusion over the fact that loading the
template doesn't show any default mappings. This docs change clarifies that in
order to see all mappings in the template, you must pass include_type_name.

Addresses #48427.

In 7.x, an index template will fail to apply if it contains a `_default_`
mapping. Several users have expressed confusion over the fact that loading the
template doesn't show any default mappings. This docs change clarifies that in
order to see all mappings in the template, you must pass `include_type_name`.
@jtibshirani jtibshirani added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types labels Apr 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left a nit that you can feel free to ignore.

LGTM so long as CI is happy!

docs/reference/migration/migrate_7_0/mappings.asciidoc Outdated Show resolved Hide resolved
@jtibshirani
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/1

@jtibshirani
Copy link
Contributor Author

Thanks for the review!

@jtibshirani jtibshirani merged commit 475b210 into elastic:7.x Apr 7, 2020
@jtibshirani jtibshirani deleted the default-mapping-in-template branch April 7, 2020 22:18
jtibshirani added a commit that referenced this pull request Apr 7, 2020
In 7.x, an index template will fail to apply if it contains a `_default_`
mapping. Several users have expressed confusion over the fact that loading the
template doesn't show any default mappings. This docs change clarifies that in
order to see all mappings in the template, you must pass `include_type_name`.
jtibshirani added a commit that referenced this pull request Apr 7, 2020
In 7.x, an index template will fail to apply if it contains a `_default_`
mapping. Several users have expressed confusion over the fact that loading the
template doesn't show any default mappings. This docs change clarifies that in
order to see all mappings in the template, you must pass `include_type_name`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v7.6.3 v7.7.1 v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants