-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve guidance on removing default mappings. #54915
Merged
jtibshirani
merged 3 commits into
elastic:7.x
from
jtibshirani:default-mapping-in-template
Apr 7, 2020
Merged
Improve guidance on removing default mappings. #54915
jtibshirani
merged 3 commits into
elastic:7.x
from
jtibshirani:default-mapping-in-template
Apr 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7.x, an index template will fail to apply if it contains a `_default_` mapping. Several users have expressed confusion over the fact that loading the template doesn't show any default mappings. This docs change clarifies that in order to see all mappings in the template, you must pass `include_type_name`.
jtibshirani
added
>docs
General docs changes
:Search Foundations/Mapping
Index mappings, including merging and defining field types
labels
Apr 7, 2020
Pinging @elastic/es-search (:Search/Mapping) |
Pinging @elastic/es-docs (>docs) |
jtibshirani
force-pushed
the
default-mapping-in-template
branch
from
April 7, 2020 18:28
f5e907b
to
9df5151
Compare
talevy
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just left a nit that you can feel free to ignore.
LGTM so long as CI is happy!
@elasticmachine run elasticsearch-ci/1 |
Thanks for the review! |
jtibshirani
added a commit
that referenced
this pull request
Apr 7, 2020
In 7.x, an index template will fail to apply if it contains a `_default_` mapping. Several users have expressed confusion over the fact that loading the template doesn't show any default mappings. This docs change clarifies that in order to see all mappings in the template, you must pass `include_type_name`.
jtibshirani
added a commit
that referenced
this pull request
Apr 7, 2020
In 7.x, an index template will fail to apply if it contains a `_default_` mapping. Several users have expressed confusion over the fact that loading the template doesn't show any default mappings. This docs change clarifies that in order to see all mappings in the template, you must pass `include_type_name`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>docs
General docs changes
:Search Foundations/Mapping
Index mappings, including merging and defining field types
v7.6.3
v7.7.1
v7.8.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7.x, an index template will fail to apply if it contains a
_default_
mapping. Several users have expressed confusion over the fact that loading the
template doesn't show any default mappings. This docs change clarifies that in
order to see all mappings in the template, you must pass
include_type_name
.Addresses #48427.