Exists queries to MatchNoneQueryBuilder when the field is unmapped #54857

SivagurunathanV · 2020-04-07T03:24:59Z

Have you signed the contributor license agreement?
Have you followed the contributor guidelines?
If submitting code, have you built your formula locally prior to submission with gradle check?
If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
If submitting code, have you checked that your submission is for an OS and architecture that we support?
If you are submitting this code for a class then read our policy for that.

elasticmachine · 2020-04-07T07:37:52Z

Pinging @elastic/es-search (:Search/Search)

server/src/main/java/org/elasticsearch/index/query/ExistsQueryBuilder.java

SivagurunathanV · 2020-04-09T22:13:17Z

@jpountz Updated the PR.

jpountz

Thanks, I left some suggestions to make it better.

server/src/main/java/org/elasticsearch/index/query/ExistsQueryBuilder.java

server/src/test/java/org/elasticsearch/index/query/ExistsQueryBuilderTests.java

SivagurunathanV · 2020-04-12T03:26:51Z

I updated the PR, let me know if this works.

jpountz

Thanks, this looks close to me, I only left minor comments. Can you also add a testMustRewrite test to ExistsQueryBuilderTests for unmapped fields? You can look at TermQueryBuilderTests for inspiration, I believe that is has such logic.

jpountz · 2020-04-13T11:49:07Z

server/src/main/java/org/elasticsearch/index/query/ExistsQueryBuilder.java

+                    return Collections.emptySet();
+                }
+            }
+        }


I believe that this entire if statement can be removed without affecting correctness. It is not possible to have a field that is neither and object nor a field at this stage.

But in this, if statement we are checking the field type.
MappedFieldType fieldType = context.getMapperService().fieldType(field);

Thanks I had the wrong assumption that simpleMatchToIndexName would return an empty set if the field is not mapped.

server/src/main/java/org/elasticsearch/index/query/ExistsQueryBuilder.java

SivagurunathanV · 2020-04-16T07:01:51Z

Updated the PR with tests.

jpountz

@elasticmachine test this please

jpountz · 2020-04-16T12:05:57Z

server/src/main/java/org/elasticsearch/index/query/ExistsQueryBuilder.java

+                    return Collections.emptySet();
+                }
+            }
+        }


Thanks I had the wrong assumption that simpleMatchToIndexName would return an empty set if the field is not mapped.

jpountz · 2020-04-16T12:10:17Z

@elasticmachine test this please

SivagurunathanV · 2020-04-16T15:43:09Z

@jpountz Merged lastest master. Please trigger the test?

SivagurunathanV · 2020-04-18T00:22:16Z

@jpountz any update?

jpountz · 2020-04-18T13:26:36Z

@elasticmachine test this please

SivagurunathanV · 2020-04-18T17:51:54Z

@jpountz I didn't find any test failure related to my changes. Am I missing something here? Thanks

jpountz · 2020-04-21T13:51:44Z

@elasticmachine update master

jpountz · 2020-04-21T13:52:39Z

@elasticmachine test this please

jpountz · 2020-04-21T13:53:01Z

@SivagurunathanV Agreed, this looks like a transient failure. I triggered a new build.

jpountz · 2020-04-21T14:45:05Z

@SivagurunathanV Can you merge master again?

SivagurunathanV · 2020-04-21T16:59:39Z

@jpountz I merged the latest master. Please trigger a new build to check.

jpountz · 2020-04-21T17:03:03Z

@elasticmachine test this please

SivagurunathanV · 2020-04-21T18:12:01Z

@jpountz passed 🎉

SivagurunathanV · 2020-04-26T16:53:59Z

@jpountz Can you please merge this PR?

…lastic#54857) Closes elastic#54062

SivagurunathanV added 4 commits April 5, 2020 23:12

Initial Commit

84639ee

Merge remote-tracking branch 'upstream/master'

1ace54c

Merge remote-tracking branch 'upstream/master'

cce05da

Refactor

a6a8166

SivagurunathanV mentioned this pull request Apr 7, 2020

Rewrite exists queries to MatchNoneQueryBuilder when the field is unmapped #54062

Closed

henningandersen added :Search/Search Search-related issues that do not fall into other categories >enhancement labels Apr 7, 2020

jpountz requested changes Apr 7, 2020

View reviewed changes

server/src/main/java/org/elasticsearch/index/query/ExistsQueryBuilder.java Outdated Show resolved Hide resolved

SivagurunathanV added 2 commits April 7, 2020 16:30

Refactored

6e00e7d

Refactoring the comment section

bbfb2fb

jpountz requested changes Apr 10, 2020

View reviewed changes

SivagurunathanV added 3 commits April 11, 2020 20:20

Refactoring review comments

274cf43

Indentation changes

fef8b0a

Indendation again

13901cb

jpountz reviewed Apr 13, 2020

View reviewed changes

Adding test for rewrite

73ba747

jpountz reviewed Apr 16, 2020

View reviewed changes

jpountz approved these changes Apr 16, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master'

c969bc1

Merge remote-tracking branch 'upstream/master'

44afde6

Merge remote-tracking branch 'upstream/master'

7a3ec01

jpountz merged commit e161757 into elastic:master Apr 27, 2020

jpountz pushed a commit to jpountz/elasticsearch that referenced this pull request Apr 27, 2020

Exists queries to MatchNoneQueryBuilder when the field is unmapped (e…

148310e

…lastic#54857) Closes elastic#54062

jpountz added v7.8.0 v8.0.0 labels Apr 27, 2020

jpountz mentioned this pull request Apr 27, 2020

Exists queries to MatchNoneQueryBuilder when the field is unmapped #55785

Merged

cbuescher mentioned this pull request Apr 30, 2020

Fix ExistsQueryBuilder#testToQuery failure #56006

Merged

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exists queries to MatchNoneQueryBuilder when the field is unmapped #54857

Exists queries to MatchNoneQueryBuilder when the field is unmapped #54857

SivagurunathanV commented Apr 7, 2020

elasticmachine commented Apr 7, 2020

SivagurunathanV commented Apr 9, 2020

jpountz left a comment

SivagurunathanV commented Apr 12, 2020

jpountz left a comment •

edited

Loading

jpountz Apr 13, 2020

SivagurunathanV Apr 16, 2020

jpountz Apr 16, 2020

SivagurunathanV commented Apr 16, 2020

jpountz left a comment

jpountz Apr 16, 2020

jpountz commented Apr 16, 2020

SivagurunathanV commented Apr 16, 2020 •

edited

Loading

SivagurunathanV commented Apr 18, 2020

jpountz commented Apr 18, 2020

SivagurunathanV commented Apr 18, 2020

jpountz commented Apr 21, 2020

jpountz commented Apr 21, 2020

jpountz commented Apr 21, 2020

jpountz commented Apr 21, 2020

SivagurunathanV commented Apr 21, 2020

jpountz commented Apr 21, 2020

SivagurunathanV commented Apr 21, 2020 •

edited

Loading

SivagurunathanV commented Apr 26, 2020 •

edited

Loading

Exists queries to MatchNoneQueryBuilder when the field is unmapped #54857

Exists queries to MatchNoneQueryBuilder when the field is unmapped #54857

Conversation

SivagurunathanV commented Apr 7, 2020

elasticmachine commented Apr 7, 2020

SivagurunathanV commented Apr 9, 2020

jpountz left a comment

Choose a reason for hiding this comment

SivagurunathanV commented Apr 12, 2020

jpountz left a comment • edited Loading

Choose a reason for hiding this comment

jpountz Apr 13, 2020

Choose a reason for hiding this comment

SivagurunathanV Apr 16, 2020

Choose a reason for hiding this comment

jpountz Apr 16, 2020

Choose a reason for hiding this comment

SivagurunathanV commented Apr 16, 2020

jpountz left a comment

Choose a reason for hiding this comment

jpountz Apr 16, 2020

Choose a reason for hiding this comment

jpountz commented Apr 16, 2020

SivagurunathanV commented Apr 16, 2020 • edited Loading

SivagurunathanV commented Apr 18, 2020

jpountz commented Apr 18, 2020

SivagurunathanV commented Apr 18, 2020

jpountz commented Apr 21, 2020

jpountz commented Apr 21, 2020

jpountz commented Apr 21, 2020

jpountz commented Apr 21, 2020

SivagurunathanV commented Apr 21, 2020

jpountz commented Apr 21, 2020

SivagurunathanV commented Apr 21, 2020 • edited Loading

SivagurunathanV commented Apr 26, 2020 • edited Loading

jpountz left a comment •

edited

Loading

SivagurunathanV commented Apr 16, 2020 •

edited

Loading

SivagurunathanV commented Apr 21, 2020 •

edited

Loading

SivagurunathanV commented Apr 26, 2020 •

edited

Loading