Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unassign DFA tasks in SetUpgradeModeAction #54523

Merged

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Mar 31, 2020

This PR unassigns Data Frame Analytics tasks from the node (the same way as Job and Datafeed tasks) when enabling ML upgrade mode.

Relates #54326

@przemekwitek przemekwitek force-pushed the upgrade_mode_unassign_dfa_tasks branch 3 times, most recently from ceba147 to 97414ca Compare April 1, 2020 11:24
@przemekwitek przemekwitek removed the WIP label Apr 1, 2020
@przemekwitek przemekwitek changed the title [DRAFT] Unassign DFA tasks in SetUpgradeModeAction Unassign DFA tasks in SetUpgradeModeAction Apr 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek przemekwitek marked this pull request as ready for review April 1, 2020 11:26
@przemekwitek przemekwitek force-pushed the upgrade_mode_unassign_dfa_tasks branch 2 times, most recently from f197a20 to c020995 Compare April 6, 2020 14:25
@przemekwitek przemekwitek force-pushed the upgrade_mode_unassign_dfa_tasks branch 5 times, most recently from e5d67cd to fe0d161 Compare April 10, 2020 13:12
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a question.

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants