-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unassign DFA tasks in SetUpgradeModeAction #54523
Merged
przemekwitek
merged 8 commits into
elastic:master
from
przemekwitek:upgrade_mode_unassign_dfa_tasks
Apr 14, 2020
Merged
Unassign DFA tasks in SetUpgradeModeAction #54523
przemekwitek
merged 8 commits into
elastic:master
from
przemekwitek:upgrade_mode_unassign_dfa_tasks
Apr 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
upgrade_mode_unassign_dfa_tasks
branch
3 times, most recently
from
April 1, 2020 11:24
ceba147
to
97414ca
Compare
przemekwitek
changed the title
[DRAFT] Unassign DFA tasks in SetUpgradeModeAction
Unassign DFA tasks in SetUpgradeModeAction
Apr 1, 2020
Pinging @elastic/ml-core (:ml) |
przemekwitek
force-pushed
the
upgrade_mode_unassign_dfa_tasks
branch
2 times, most recently
from
April 6, 2020 14:25
f197a20
to
c020995
Compare
przemekwitek
force-pushed
the
upgrade_mode_unassign_dfa_tasks
branch
5 times, most recently
from
April 10, 2020 13:12
e5d67cd
to
fe0d161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a question.
...-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/ClassificationIT.java
Outdated
Show resolved
Hide resolved
...-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/ClassificationIT.java
Outdated
Show resolved
Hide resolved
dimitris-athanasiou
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…setting upgrade mode" This reverts commit ee9245e3e93794cfc576580d7696bf7cb48b7cc1.
przemekwitek
force-pushed
the
upgrade_mode_unassign_dfa_tasks
branch
from
April 14, 2020 06:23
b506bfc
to
f4c281b
Compare
przemekwitek
added a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unassigns Data Frame Analytics tasks from the node (the same way as Job and Datafeed tasks) when enabling ML upgrade mode.
Relates #54326