Resolve some coordination-layer TODOs #54511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a handful of TODO comments in the cluster coordination layer that no longer apply. Relates elastic#32006
DaveCTurner
added
>non-issue
:Distributed Coordination/Cluster Coordination
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
DaveCTurner
commented
Mar 31, 2020
| @@ -157,7 +157,6 @@ String getDescription() { | |||
| if (INITIAL_MASTER_NODES_SETTING.get(Settings.EMPTY).equals(INITIAL_MASTER_NODES_SETTING.get(settings))) { | |||
| bootstrappingDescription = "[" + INITIAL_MASTER_NODES_SETTING.getKey() + "] is empty on this node"; | |||
| } else { | |||
| // TODO update this when we can bootstrap on only a quorum of the initial nodes | |||
There was a problem hiding this comment.
Done, see call to ClusterBootstrapService::isBootstrapPlaceholder in describeQuorum.
| @@ -163,7 +163,6 @@ private void handleFollowerCheck(FollowerCheckRequest request, TransportChannel | |||
| FastResponseState responder = this.fastResponseState; | |||
|
|
|||
| if (responder.mode == Mode.FOLLOWER && responder.term == request.term) { | |||
| // TODO trigger a term bump if we voted for a different leader in this term | |||
There was a problem hiding this comment.
This happens by sending a publish response with no associated join.
| @@ -21,7 +21,6 @@ | |||
| import org.elasticsearch.cluster.ClusterState; | |||
|
|
|||
| public class InMemoryPersistedState implements CoordinationState.PersistedState { | |||
| // TODO add support and tests for behaviour with persistence-layer failures | |||
There was a problem hiding this comment.
Done, see AbstractCoordinatorTestCase.MockPersistedState.
| @@ -62,7 +62,6 @@ | |||
| this.updateMaxTermSeen = updateMaxTermSeen; | |||
| this.electionStrategy = electionStrategy; | |||
|
|
|||
| // TODO does this need to be on the generic threadpool or can it use SAME? | |||
There was a problem hiding this comment.
No, SAME is bad because updateMaxTermSeen.accept may block on Coordinator#mutex.
| @@ -244,7 +244,6 @@ void sendPublishRequest() { | |||
| assert state == PublicationTargetState.NOT_STARTED : state + " -> " + PublicationTargetState.SENT_PUBLISH_REQUEST; | |||
| state = PublicationTargetState.SENT_PUBLISH_REQUEST; | |||
| Publication.this.sendPublishRequest(discoveryNode, publishRequest, new PublishResponseHandler()); | |||
| // TODO Can this ^ fail with an exception? Target should be failed if so. | |||
There was a problem hiding this comment.
Don't think so, it notifies the listener on a failure.
| @@ -244,7 +244,6 @@ protected static int defaultInt(Setting<Integer> setting) { | |||
|
|
|||
| final List<ClusterNode> clusterNodes; | |||
| final DeterministicTaskQueue deterministicTaskQueue = new DeterministicTaskQueue( | |||
| // TODO does ThreadPool need a node name any more? | |||
There was a problem hiding this comment.
Not really relevant here.
| @@ -449,11 +450,6 @@ public String toString() { | |||
| deterministicTaskQueue.runRandomTask(); | |||
| } | |||
| } | |||
|
|
|||
| // TODO other random steps: | |||
There was a problem hiding this comment.
Done, or at least covered elsewhere.
DaveCTurner
added a commit
that referenced
this pull request
Apr 1, 2020
This commit removes a handful of TODO comments in the cluster coordination layer that no longer apply. Relates #32006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes a handful of TODO comments in the cluster coordination
layer that no longer apply.
Relates #32006