Do not execute ML CRUD actions when upgrade mode is enabled #54437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
upgrade_mode_actions
branch
4 times, most recently
from
3366a26 to
1c988e7
Compare
przemekwitek
force-pushed
the
upgrade_mode_actions
branch
4 times, most recently
from
0415142 to
c1bac1f
Compare
przemekwitek
changed the title
przemekwitek
force-pushed
the
upgrade_mode_actions
branch
3 times, most recently
from
d6c4281 to
db31c85
Compare
przemekwitek
force-pushed
the
upgrade_mode_actions
branch
2 times, most recently
from
a9e88d7 to
e112af1
Compare
|
Pinging @elastic/ml-core (:ml) |
droberts195
reviewed
Apr 8, 2020
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlUpgradeModeActionFilter.java
Outdated
Show resolved
Hide resolved
przemekwitek
force-pushed
the
upgrade_mode_actions
branch
from
f1a2fc6 to
7c3fec4
Compare
|
run elasticsearch-ci/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not allow ML CRUD actions to be executed when ML upgrade mode is enabled.
This is achieved using
MlUpgradeModeActionFilterthat keeps track of current cluster state so it knows whether upgrade mode is currently enabled.Relates #54326