-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async search: rename REST parameters #54198
Async search: rename REST parameters #54198
Conversation
This commit renames wait_for_completion to wait_for_completion_timeout in submit async search and get async search. Also it renames clean_on_completion to keep_on_completion and turns around its behaviour. Closes elastic#54069
Pinging @elastic/es-search (:Search/Search) |
7.7 has been FFrozen, can the |
@Mpdreamz can correct me if I am wrong, but I think that this a blocker for the language clients. As far as I understand |
It won't break the clients (unless it was an enum) but these type of changes are incredibly hard to patch after a release. Since this was discussed and agreed upon by a large group on the issueI would vote to raise it as blocker so that it can go in the next bc. Similar to #54196 |
+1 to merge to 7.7. I replaced the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two comments, LGTM otherwise
x-pack/plugin/src/test/resources/rest-api-spec/api/async_search.get.json
Show resolved
Hide resolved
This commit renames wait_for_completion to wait_for_completion_timeout in submit async search and get async search. Also it renames clean_on_completion to keep_on_completion and turns around its behaviour. Closes #54069
heads up @lukasolson you will have to rename |
This commit renames wait_for_completion to wait_for_completion_timeout in submit async search and get async search. Also it renames clean_on_completion to keep_on_completion and turns around its behaviour. Closes #54069
@lukasolson @javanna was this backported to 7.7? |
@javanna I'm asking, because backporting the kibana change to 7.7 fails in testing, while the 7.x and the 8.0 branches were working and merged |
@javanna I think I might have found the issue. Lets see how the build goes! |
@lizozom I see, let me know if I can do anything to help. |
This commit renames
wait_for_completion
towait_for_completion_timeout
in submit async search and get async search.Also it renames
clean_on_completion
tokeep_on_completion
and turns around its behaviour.Closes #54069