Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Reformat keyword_marker token filter #54076

Merged
merged 1 commit into from
Mar 25, 2020
Merged

[DOCS] Reformat keyword_marker token filter #54076

merged 1 commit into from
Mar 25, 2020

Conversation

jrodewig
Copy link
Contributor

Makes the following changes to the keyword_marker token filter docs:

  • Rewrites description and adds Lucene link
  • Adds detailed analyze example
  • Rewrites parameter definitions
  • Adds custom analyzer and filter example

Makes the following changes to the `keyword_marker` token filter docs:

* Rewrites description and adds Lucene link
* Adds detailed analyze example
* Rewrites parameter definitions
* Adds custom analyzer and filter example
@jrodewig jrodewig added >docs General docs changes :Search Relevance/Analysis How text is split into tokens labels Mar 24, 2020
@jrodewig jrodewig requested a review from romseygeek March 24, 2020 12:29
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point we want to deprecate this in favour of conditional_token_filter but I don't think we're quite ready for that yet.

@jrodewig
Copy link
Contributor Author

Thanks @romseygeek.

@jrodewig jrodewig merged commit 4f503bf into elastic:master Mar 25, 2020
@jrodewig jrodewig deleted the docs__reformat-keyword-marker-tokenfilter branch March 25, 2020 13:01
jrodewig added a commit that referenced this pull request Mar 25, 2020
Makes the following changes to the `keyword_marker` token filter docs:

* Rewrites description and adds Lucene link
* Adds detailed analyze example
* Rewrites parameter definitions
* Adds custom analyzer and filter example
jrodewig added a commit that referenced this pull request Mar 25, 2020
Makes the following changes to the `keyword_marker` token filter docs:

* Rewrites description and adds Lucene link
* Adds detailed analyze example
* Rewrites parameter definitions
* Adds custom analyzer and filter example
@jrodewig
Copy link
Contributor Author

jrodewig commented Mar 25, 2020

Backport commits

master 4f503bf
7.x 74051d6
7.7 3687043
7.6 01baa38

jrodewig added a commit that referenced this pull request Mar 25, 2020
Makes the following changes to the `keyword_marker` token filter docs:

* Rewrites description and adds Lucene link
* Adds detailed analyze example
* Rewrites parameter definitions
* Adds custom analyzer and filter example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants