Implement aggregations on aggregate metrics #53986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csoulios
added
WIP
:StorageEngine/Rollup
|
Pinging @elastic/es-analytics-geo (:Analytics/Rollup) |
Make parsing of malformed values stricter and ignore all field metrics even if a single metric is wrong
isFieldWithinQuery to handle range queries efficiently, fielddataBuilder to handle aggregations and sort, docValueFormat to format double correctly
metrics should be an error.
Now AggregateMetricsValuesSource returns directly a SortedNumericDoubleValues instance which received by the aggregator
And fixed issues that were discovered in the process of testing
|
@elasticmachine run elasticsearch-ci/2 |
|
@elasticmachine run elasticsearch-ci/default-distro |
|
@elasticmachine run elasticsearch-ci/bwc |
on aggregate metric fields
csoulios
commented
Apr 28, 2020
...in/java/org/elasticsearch/xpack/aggregatemetric/mapper/AggregateDoubleMetricFieldMapper.java
Show resolved
Hide resolved
rjernst
added
the
Team:Analytics
|
@elasticmachine run elasticsearch-ci/2 |
|
@elasticmachine run elasticsearch-ci/bwc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the implementation of the
aggregate_metric_doublefield mapper(#49830) we are implementing the Min, Max, ValueCount, Sum and Average aggregations on aggregate metrics.The code builds on the excellent work done for #42949 and uses the extensible ValuesSources infrastructure to wire up common metric aggregation on the
aggregate_metric_doublefield type.This PR is part of the rollups v2 refactoring as described in meta issue #42720