Missed an annotation #53755
Closed
Missed an annotation #53755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
nik9000
approved these changes
Mar 18, 2020
|
@elasticmachine run elasticsearch-ci/bwc |
not-napoleon
changed the base branch from
feature/extensible-values-source
to
master
not-napoleon
changed the base branch from
master
to
feature/extensible-values-source
|
Going to reopen this against master; It's less work to do that than to figure out why git wants to merge 14000 lines from here into master if I change the target. |
not-napoleon
deleted the
vs-refactor-add-override-annotation-histogram-vs
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this while looking at how we implemented the histogram values source. Method is clearly an override, was just missing the annotation.