Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly require that delegate API keys have no privileges #53647

Merged
merged 5 commits into from
Mar 17, 2020

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Mar 17, 2020

The current implicit behaviour is that when an API keys is used to create another API key,
the child key is created without any privilege. This implicit behaviour is surprising and is
a source of confusion for users. This change makes that behaviour explicit.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authorization)

@ywangd ywangd added >bug and removed >refactoring labels Mar 17, 2020
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd changed the title Code re-structure for consistent behaviour Explicitly require that delegate API keys have no privileges Mar 17, 2020
@ywangd ywangd merged commit b67863e into elastic:master Mar 17, 2020
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Mar 17, 2020
…53647)

The current implicit behaviour is that when an API keys is used to create another API key,
the child key is created without any privilege. This implicit behaviour is surprising and is
a source of confusion for users.

This change makes that behaviour explicit.
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Mar 17, 2020
…53647)

The current implicit behaviour is that when an API keys is used to create another API key,
the child key is created without any privilege. This implicit behaviour is surprising and is
a source of confusion for users.

This change makes that behaviour explicit.
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Mar 17, 2020
…53647)

The current implicit behaviour is that when an API keys is used to create another API key,
the child key is created without any privilege. This implicit behaviour is surprising and is
a source of confusion for users.

This change makes that behaviour explicit.
ywangd added a commit that referenced this pull request Mar 17, 2020
…53648)

The current implicit behaviour is that when an API keys is used to create another API key,
the child key is created without any privilege. This implicit behaviour is surprising and is
a source of confusion for users.

This change makes that behaviour explicit.
@ywangd
Copy link
Member Author

ywangd commented Mar 17, 2020

Backports:

  • v7.7.0 - Done
  • v7.6.2 - Done
  • v6.8.8 - Done

jkakavas pushed a commit that referenced this pull request Mar 17, 2020
…53649)

The current implicit behaviour is that when an API keys is used to create another API key,
the child key is created without any privilege. This implicit behaviour is surprising and is
a source of confusion for users.

This change makes that behaviour explicit.
ywangd added a commit that referenced this pull request Mar 17, 2020
…53650)

* Explicitly require that derived API keys have no privileges (#53647)

The current implicit behaviour is that when an API keys is used to create another API key,
the child key is created without any privilege. This implicit behaviour is surprising and is
a source of confusion for users.

This change makes that behaviour explicit.
tvernum added a commit to tvernum/elasticsearch that referenced this pull request Sep 15, 2020
This updates the Create API Key reference document with
information about the limitations of derived API keys.

Since ES v7.6.0, API keys that are created from an API key (what we
refer to as "derived API keys" must be created with an empty
privileges list (to explicitly match the effective behaviour of all
earlier versions).

This information was included in the release notes, but didn't get
added to the API reference.

Relates: elastic#53647, elastic#54522, elastic#60154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants