-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly require that delegate API keys have no privileges #53647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>refactoring
:Security/Authorization
Roles, Privileges, DLS/FLS, RBAC/ABAC
v8.0.0
v7.7.0
v7.6.2
v6.8.8
labels
Mar 17, 2020
Pinging @elastic/es-security (:Security/Authorization) |
tvernum
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ywangd
changed the title
Code re-structure for consistent behaviour
Explicitly require that delegate API keys have no privileges
Mar 17, 2020
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Mar 17, 2020
…53647) The current implicit behaviour is that when an API keys is used to create another API key, the child key is created without any privilege. This implicit behaviour is surprising and is a source of confusion for users. This change makes that behaviour explicit.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Mar 17, 2020
…53647) The current implicit behaviour is that when an API keys is used to create another API key, the child key is created without any privilege. This implicit behaviour is surprising and is a source of confusion for users. This change makes that behaviour explicit.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Mar 17, 2020
…53647) The current implicit behaviour is that when an API keys is used to create another API key, the child key is created without any privilege. This implicit behaviour is surprising and is a source of confusion for users. This change makes that behaviour explicit.
ywangd
added a commit
that referenced
this pull request
Mar 17, 2020
…53648) The current implicit behaviour is that when an API keys is used to create another API key, the child key is created without any privilege. This implicit behaviour is surprising and is a source of confusion for users. This change makes that behaviour explicit.
Backports:
|
jkakavas
pushed a commit
that referenced
this pull request
Mar 17, 2020
…53649) The current implicit behaviour is that when an API keys is used to create another API key, the child key is created without any privilege. This implicit behaviour is surprising and is a source of confusion for users. This change makes that behaviour explicit.
ywangd
added a commit
that referenced
this pull request
Mar 17, 2020
…53650) * Explicitly require that derived API keys have no privileges (#53647) The current implicit behaviour is that when an API keys is used to create another API key, the child key is created without any privilege. This implicit behaviour is surprising and is a source of confusion for users. This change makes that behaviour explicit.
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Sep 15, 2020
This updates the Create API Key reference document with information about the limitations of derived API keys. Since ES v7.6.0, API keys that are created from an API key (what we refer to as "derived API keys" must be created with an empty privileges list (to explicitly match the effective behaviour of all earlier versions). This information was included in the release notes, but didn't get added to the API reference. Relates: elastic#53647, elastic#54522, elastic#60154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Security/Authorization
Roles, Privileges, DLS/FLS, RBAC/ABAC
v6.8.8
v7.6.2
v7.7.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implicit behaviour is that when an API keys is used to create another API key,
the child key is created without any privilege. This implicit behaviour is surprising and is
a source of confusion for users. This change makes that behaviour explicit.