Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning when doc scripts refer to '_type' field #53605

Merged
merged 3 commits into from
Mar 18, 2020

Conversation

romseygeek
Copy link
Contributor

We currently emit a warning in 8x when a script refers to the _type field for
a document. However, in 8x this field no longer exists, so the deprecation
warning is not required.

Relates to #41059

@romseygeek romseygeek added >non-issue :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.0.0 labels Mar 16, 2020
@romseygeek romseygeek self-assigned this Mar 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for removing this.

@romseygeek romseygeek merged commit 795a927 into elastic:master Mar 18, 2020
@jpountz jpountz mentioned this pull request Mar 18, 2020
66 tasks
@pgomulka pgomulka mentioned this pull request Mar 25, 2020
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >non-issue v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants