Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove force as valid value for version_type parameter #53428

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

Gunnerva
Copy link
Contributor

force is no longer a valid option for the version_type: flag -- this impacts at least version 6.8 and later.

Using force results in:

Error message from 6.8
{
"error": {
"root_cause": [
{
"type": "action_request_validation_exception",
"reason": "Validation Failed: 1: version type [force] may no longer be used;"
}
],
"type": "action_request_validation_exception",
"reason": "Validation Failed: 1: version type [force] may no longer be used;"
},
"status": 400
}

Error message from 7.6:
{
"error" : {
"root_cause" : [
{
"type" : "x_content_parse_exception",
"reason" : "[8:21] [dest] failed to parse field [version_type]"
}
],
"type" : "x_content_parse_exception",
"reason" : "[8:21] [reindex] failed to parse field [dest]",
"caused_by" : {
"type" : "x_content_parse_exception",
"reason" : "[8:21] [dest] failed to parse field [version_type]",
"caused_by" : {
"type" : "illegal_argument_exception",
"reason" : "No version type match [force]"
}
}
},
"status" : 400
}

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

force is no longer a valid option for the version_type: flag -- this impacts at least version 6.8 and later.

Using force results in:

Error message from 6.8
{
  "error": {
    "root_cause": [
      {
        "type": "action_request_validation_exception",
        "reason": "Validation Failed: 1: version type [force] may no longer be used;"
      }
    ],
    "type": "action_request_validation_exception",
    "reason": "Validation Failed: 1: version type [force] may no longer be used;"
  },
  "status": 400
}

Error message from 7.6:
{
  "error" : {
    "root_cause" : [
      {
        "type" : "x_content_parse_exception",
        "reason" : "[8:21] [dest] failed to parse field [version_type]"
      }
    ],
    "type" : "x_content_parse_exception",
    "reason" : "[8:21] [reindex] failed to parse field [dest]",
    "caused_by" : {
      "type" : "x_content_parse_exception",
      "reason" : "[8:21] [dest] failed to parse field [version_type]",
      "caused_by" : {
        "type" : "illegal_argument_exception",
        "reason" : "No version type match [force]"
      }
    }
  },
  "status" : 400
}
@Gunnerva Gunnerva requested a review from debadair March 12, 2020 14:21
@jrodewig jrodewig added the >docs General docs changes label Mar 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@jrodewig jrodewig added the :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. label Mar 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CRUD)

@jrodewig jrodewig changed the title Update common-parms.asciidoc [DOCS] Remove force as valid value from version_type parameter Mar 16, 2020
@jrodewig jrodewig changed the title [DOCS] Remove force as valid value from version_type parameter [DOCS] Remove force as valid value for version_type parameter Mar 16, 2020
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for raising this @Gunnerva.

@jrodewig jrodewig merged commit 12e2485 into master Mar 16, 2020
@jrodewig jrodewig deleted the Gunnerva-patch-1 branch March 16, 2020 20:41
jrodewig pushed a commit that referenced this pull request Mar 16, 2020
The `force` value for the `version_type` parameter was deprecated in 6.8.

This removes the value from the parameter definition.
jrodewig pushed a commit that referenced this pull request Mar 16, 2020
The `force` value for the `version_type` parameter was deprecated in 6.8.

This removes the value from the parameter definition.
@jrodewig
Copy link
Contributor

Backport commits

master 12e2485
7.x b4e203a
7.6 ab94fc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes v7.6.2 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants