[ML] Rename data frame analytics maximum_number_trees to max_trees #53300
Conversation
Deprecates `maximum_number_trees` parameter of classification and regression and replaces it with `max_trees`.
|
Pinging @elastic/ml-core (:ml) |
| @@ -43,6 +43,9 @@ | |||
| "maximum_number_trees" : { | |||
There was a problem hiding this comment.
You can remove the old mapping can't you? If a new index is being created we don't need it and if the index is an old one then the mapping is already present?
There was a problem hiding this comment.
It makes sense to keep it around for the possibility that a job using the old field name is cloned into a new index.
There was a problem hiding this comment.
Won't the cloned job go through the process of renaming the field automatically as it is parsed and written out to xcontent.
I think what is bothering me is that we can't comment on the mapping json // remove this at 9.0.0 and no doubt it will be forgotten about. If it can go now I'd rather we get rid of it.
Can you at least try removing the old mapping and see if the upgrade tests pass please
There was a problem hiding this comment.
That's a good point. There is a test failing but I can fix the test. I'll give it a go.
|
@elasticmachine update branch |
dimitris-athanasiou
force-pushed
the
rename-df-analytics-maximum-number-trees-to-max-trees
branch
from
8584c94 to
e46e008
Compare
|
@elasticmachine update branch |
dimitris-athanasiou
deleted the
rename-df-analytics-maximum-number-trees-to-max-trees
branch
Deprecates
maximum_number_treesparameter of classification andregression and replaces it with
max_trees.