Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILM Freeze step retry when not acknowledged #53287

Conversation

henningandersen
Copy link
Contributor

A freeze operation can partially fail in multiple places, including the
close verification step. This left the index in an unfrozen but
partially closed state. Now throw an exception to retry the freeze step
instead.

A freeze operation can partially fail in multiple places, including the
close verification step. This left the index in an unfrozen but
partially closed state. Now throw an exception to retry the freeze step
instead.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Henning!

@henningandersen
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/2

I tried to run the failing test multiple times locally. It looks like other tests in the area are unstable too. And TimeSeriesLifecycleActionsIT.testHistoryIsWrittenWithSuccess failed a few times in the past days.

So retrying to see if it fails again.

@henningandersen henningandersen merged commit 6bd3509 into elastic:master Mar 10, 2020
henningandersen added a commit that referenced this pull request Mar 10, 2020
A freeze operation can partially fail in multiple places, including the
close verification step. This left the index in an unfrozen but
partially closed state. Now throw an exception to retry the freeze step
instead.
henningandersen added a commit that referenced this pull request Mar 10, 2020
A freeze operation can partially fail in multiple places, including the
close verification step. This left the index in an unfrozen but
partially closed state. Now throw an exception to retry the freeze step
instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants