Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValuesSource refactoring: Wire up ExtendedStats aggregation #53227

Conversation

csoulios
Copy link
Contributor

@csoulios csoulios commented Mar 6, 2020

Wire up ExtendedStats aggregation for #42949

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@csoulios csoulios changed the title ValuesSource refactoring: Wire up median ExtendedStats aggregation ValuesSource refactoring: Wire up ExtendedStats aggregation Mar 6, 2020
Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We've seen that CI failure on a few PRs, and I think Tal pulled in the fix from master. If you merge the feature branch, it should go to green.

@csoulios
Copy link
Contributor Author

csoulios commented Mar 9, 2020

@elasticmachine run elasticsearch-ci/bwc
@elasticmachine run elasticsearch-ci/default-distro

@csoulios
Copy link
Contributor Author

csoulios commented Mar 9, 2020

@elasticmachine run elasticsearch-ci/bwc

@csoulios
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/bwc
@elasticmachine run elasticsearch-ci/default-distro

@csoulios csoulios merged commit 475a0ce into elastic:feature/extensible-values-source Mar 16, 2020
@csoulios csoulios deleted the vs-refactor-wire-up-extended-stats branch March 16, 2020 14:31
not-napoleon pushed a commit to not-napoleon/elasticsearch that referenced this pull request Mar 26, 2020
not-napoleon added a commit that referenced this pull request Mar 31, 2020
* ValuesSource refactor wire up missing agg (#53511)

Part of refactoring ValuesSource in #42949

* ValuesSource refactoring: Wire up ExtendedStats aggregation (#53227)

* Javadoc for ValuesSource related work (#53427)

Co-authored-by: Andy Bristol <[email protected]>
Co-authored-by: Christos Soulios <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants