Specify security.get_role_mapping name as list #53207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the rest API spec for security.get_role_mapping to specify name as a list type. Multiple values can be specified for name as a comma-separated list.
tvernum
added
the
:Security/Authentication
|
Pinging @elastic/es-security (:Security/Authentication) |
|
@russcam are you still wanting to progress this PR or should it be closed? |
|
Yes I am @colings86. If it LGTY , I can merge it in and backport |
|
@elastic/es-security could someone take this and work with @russcam to get it merged by reviewing the change? |
|
@russcam apologies that this fell through the cracks. Do you mind tackling the |
|
no worries @jkakavas , I'll update |
This commit updates the REST API spec for security.get_role to specify name as a list type.
|
@elasticmachine update branch |
|
I just discovered that this PR has not been backported to 7.x and 7.10 branches. This affects the generation of the clients, since we use the API spec. |
ezimuel
pushed a commit
to ezimuel/elasticsearch
that referenced
this pull request
Oct 16, 2020
…lastic#53207) This commit updates the rest API specs for - security.get_role_mapping to specify name as a list type. - security.get_role to specify name as a list type.
ezimuel
added a commit
that referenced
this pull request
Oct 16, 2020
…53207) (#63786) This commit updates the rest API specs for - security.get_role_mapping to specify name as a list type. - security.get_role to specify name as a list type. Co-authored-by: Russ Cam <[email protected]>
ezimuel
added a commit
that referenced
this pull request
Oct 16, 2020
…53207) (#63785) This commit updates the rest API specs for - security.get_role_mapping to specify name as a list type. - security.get_role to specify name as a list type. Co-authored-by: Russ Cam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the rest API spec for
security.get_role_mapping to specify name as a list type.
Multiple values can be specified for name as a comma-separated list.