Fix Get Alias API handling of hidden indices with visible aliases #53147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the Get Aliases API to include hidden indices by default - this is slightly different from other APIs, but is necessary to make this API work intuitively.
gwbrown
added
>non-issue
:Data Management/Indices APIs
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
jaymode
approved these changes
Mar 5, 2020
Comment on lines
413
to
414
| * @return indices option that requires every specified index to exist, expands wildcards to both open and closed indices, and includes | ||
| * hidden indices and allows that no indices are resolved from wildcard expressions (not returning an error). |
There was a problem hiding this comment.
Suggested change
| * @return indices option that requires every specified index to exist, expands wildcards to both open and closed indices, and includes | |
| * hidden indices and allows that no indices are resolved from wildcard expressions (not returning an error). | |
| * @return indices option that requires every specified index to exist, expands wildcards to both open and closed indices, includes | |
| * hidden indices, and allows that no indices are resolved from wildcard expressions (not returning an error). |
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Mar 7, 2020
…astic#53147) This commit changes the Get Aliases API to include hidden indices by default - this is slightly different from other APIs, but is necessary to make this API work intuitively.
gwbrown
added a commit
that referenced
this pull request
Mar 9, 2020
…3147) This commit changes the Get Aliases API to include hidden indices by default - this is slightly different from other APIs, but is necessary to make this API work intuitively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the Get Aliases API to include hidden indices by
default - this is slightly different from other APIs, but is necessary
to make this API work intuitively.
Relates to elastic/kibana#58722 (comment)
Labelled
non-issueas hidden aliases have not yet shipped, so this bug isn't relevant to the release notes.