Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests in GeoBoundsAggregatorTests #53033

Merged
merged 3 commits into from
Mar 3, 2020

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Mar 2, 2020

this commit introduces more thorough field-type support tests
as well as tests for unmapped and missing values.

relates #42949.

this commit introduces more thorough field-type support tests
as well as tests for unmapped and missing values.

relates elastic#42949.
@talevy talevy added >test Issues or PRs that are addressing/adding tests :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 labels Mar 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would like to address the naming question on testUnmappedWithNoDocs, but the rest of the comments are just nits that you can accept or ignore as you like.

@talevy
Copy link
Contributor Author

talevy commented Mar 3, 2020

thanks Mark, updated!

@talevy talevy merged commit 4b33908 into elastic:master Mar 3, 2020
@talevy talevy deleted the geobounds-unittests branch March 3, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants