Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] fix NPE in derive stats if shouldStopAtNextCheckpoint is set #52940

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

hendrikmuhs
Copy link

fixes a NPE in _stats in case shouldStopAtNextCheckpoint is set.

Dear reviewer, please start with: d26a5f9, the 1st commit applies only code formatting

Note: shouldStopAtNextCheckpoint is default false and the exception is handled internally before surfacing. The bug has therefore low severity: A user only experiences an exception in the log.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@hendrikmuhs
Copy link
Author

run elasticsearch-ci/bwc
run elasticsearch-ci/default-distro

Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now the pr tags say v7.0.0. I am not sure you meant to indicate the bug fix will go back to v7.0.0

@hendrikmuhs hendrikmuhs added v7.7.0 and removed v7.0.0 labels Feb 28, 2020
@hendrikmuhs
Copy link
Author

right now the pr tags say v7.0.0. I am not sure you meant to indicate the bug fix will go back to v7.0.0

nope, it should be v7.7.0, I just clicked the wrong version

@hendrikmuhs hendrikmuhs force-pushed the transform-deriveStats-NPE branch from d26a5f9 to 835355a Compare February 28, 2020 13:38
@hendrikmuhs hendrikmuhs merged commit 6a5f78d into elastic:master Mar 2, 2020
@hendrikmuhs hendrikmuhs deleted the transform-deriveStats-NPE branch March 2, 2020 07:02
hendrikmuhs pushed a commit that referenced this pull request Mar 2, 2020
fixes a NPE in _stats in case shouldStopAtNextCheckpoint is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants