Fix ingest pipeline _simulate api with empty docs never returns a res… #52937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
the
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
|
@elasticmachine update branch |
danhermann
suggested changes
Mar 2, 2020
There was a problem hiding this comment.
@gaobinlong, thank you for fixing this bug. I made a couple minor suggestions for the error messages. Otherwise, this looks great and I'll get it merged in.
server/src/main/java/org/elasticsearch/action/ingest/SimulatePipelineRequest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/action/ingest/SimulatePipelineRequestParsingTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/ingest/SimulatePipelineRequest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/action/ingest/SimulatePipelineRequestParsingTests.java
Outdated
Show resolved
Hide resolved
martijnvg
reviewed
Mar 2, 2020
server/src/main/java/org/elasticsearch/action/ingest/SimulateExecutionService.java
Show resolved
Hide resolved
|
Thanks @danhermann and @martijnvg, I have made a new commit which contains some changes following your comment. Can you have a look on that? |
|
@elasticmachine update branch |
|
@elasticmachine ok to test |
|
Thanks for the fix, @gaobinlong! I'll get this merged now. |
danhermann
pushed a commit
to danhermann/elasticsearch
that referenced
this pull request
Mar 11, 2020
danhermann
added a commit
that referenced
this pull request
Mar 11, 2020
danhermann
pushed a commit
to danhermann/elasticsearch
that referenced
this pull request
Mar 13, 2020
danhermann
added a commit
that referenced
this pull request
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to #52833.
The main changes are: