Updates to TESTING.asciidoc for REST testing #52862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelandis
added
>docs
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
Pinging @elastic/es-docs (>docs) |
mark-vieira
approved these changes
Feb 27, 2020
| --------------------------------------------------------------------------- | ||
| restResources { | ||
| restApi { | ||
| includeCore '_common', 'indices', 'index', 'cluster', 'nodes', 'get', 'ingest' |
There was a problem hiding this comment.
Is the underscore prefix to "common" required?
There was a problem hiding this comment.
yeah it's required to match the pattern
This will result in a pattern match of _common*/**. The file we are matching is _common.json. The api's don't use use folders, so we could change the pattern match to be *common*.json, however the tests do use folders so those would need to stay <prefix>*/** (or the like). I figured a simple prefix match for both would be simplest to reason about, but am open to change (in a different PR)
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Feb 27, 2020
Update documentation for: * restResources config (related elastic#52114) * call out YAML vs. Java based Rest tests * update example to use newer syntax * update example to target a test that is not skipped * provide example for bwcRest test (related elastic#52383)
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Feb 27, 2020
Update documentation for: * restResources config (related elastic#52114) * call out YAML vs. Java based Rest tests * update example to use newer syntax * update example to target a test that is not skipped * provide example for bwcRest test (related elastic#52383)
|
I've removed the backport pending label as this looks to have been merged into 7.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation for: