Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO in MaxSizeCondition #52854

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Remove TODO in MaxSizeCondition #52854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/action/admin/indices/rollover/MaxAgeCondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public String getWriteableName() {

@Override
public void writeTo(StreamOutput out) throws IOException {
// While we technically could serialize this would out.writeTimeValue(...), that would
// While we technically could serialize this with out.writeTimeValue(...), that would
// require doing the song and dance around backwards compatibility for this value. Since
// in this case the deserialized version is not displayed to a user, it's okay to simply use
// milliseconds. It's possible to lose precision if someone were to say, specify 50
Expand Down
5 changes: 4 additions & 1 deletion server/src/main/java/org/elasticsearch/action/admin/indices/rollover/MaxSizeCondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ public String getWriteableName() {

@Override
public void writeTo(StreamOutput out) throws IOException {
//TODO here we should just use ByteSizeValue#writeTo and same for de-serialization in the constructor
// While we technically could serialize this with value.writeTo(...), that would
// require doing the song and dance around backwards compatibility for this value. Since
// in this case the deserialized version is not displayed to a user, it's okay to simply use
// bytes.
out.writeVLong(value.getBytes());
}

Expand Down