Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more assertions to testMaybeFlush #52792

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 25, 2020

We aren't able to reproduce or figure out the reason that failed this test. This commit adds more assertions so we can narrow the scope.

Relates #52223

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 labels Feb 25, 2020
@dnhatn dnhatn requested a review from ywelsch February 25, 2020 19:40
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@dnhatn
Copy link
Member Author

dnhatn commented Feb 25, 2020

Thanks Armin.

@dnhatn dnhatn merged commit c02b47c into elastic:master Feb 25, 2020
@dnhatn dnhatn deleted the maybe-flush branch February 25, 2020 20:44
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 26, 2020
We aren't able to reproduce or figure out the reason that failed this test.
This commit adds more assertions so we can narrow the scope.

Relates elastic#52223
dnhatn added a commit that referenced this pull request Feb 26, 2020
We aren't able to reproduce or figure out the reason that failed this test.
This commit adds more assertions so we can narrow the scope.

Relates #52223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants