Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track the offset of the BytesRef passed to the tree reader #52704

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Feb 24, 2020

After changes win Lucene of how binary doc values are stored, we must track the offset of the BytesRef passed to the tree reader.

@iverase iverase requested a review from talevy February 24, 2020 11:39
@iverase iverase added the :Analytics/Geo Indexing, search aggregations of geo points and shapes label Feb 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@iverase
Copy link
Contributor Author

iverase commented Feb 24, 2020

@elasticmachine run elasticsearch-ci/1

@iverase
Copy link
Contributor Author

iverase commented Feb 24, 2020

@elasticmachine run elasticsearch-ci/bwc

Copy link
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you!

@iverase iverase merged commit 004df2a into elastic:geoshape-doc-values Feb 24, 2020
@iverase iverase deleted the docValueOffset branch February 24, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants