[DOCS] Document include_in_* nested mapping parms
#52648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds documentation for the `include_in_parent` and `include_in_root` mapping parameters for the `nested` mapping datatype.
jrodewig
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-search (:Search/Mapping) |
jtibshirani
reviewed
Feb 21, 2020
|
|
||
| `include_in_parent`:: | ||
| (Optional, boolean) | ||
| If `true`, inner objects are indexed as <<object,flat key-value pairs>> for the |
There was a problem hiding this comment.
To me, this description could be hard to understand. An alternate suggestion: "If true, all fields in the nested object are also added to the parent document as standard (flat) fields." A similar suggestion applies to include_in_root below.
There was a problem hiding this comment.
Thank you for the feedback @jtibshirani. I've reworded as suggested with 817c0ff.
jtibshirani
approved these changes
Feb 24, 2020
|
|
||
| `include_in_root`:: | ||
| (Optional, boolean) | ||
| If `true`, all fields in the nested object are also added to the topmost |
There was a problem hiding this comment.
Small comment, maybe 'root document' would be a little clearer.
|
Thanks @jtibshirani. |
jrodewig
added a commit
that referenced
this pull request
Feb 25, 2020
Adds documentation for the `include_in_parent` and `include_in_root` mapping parameters for the `nested` mapping datatype.
jrodewig
added a commit
that referenced
this pull request
Feb 25, 2020
Adds documentation for the `include_in_parent` and `include_in_root` mapping parameters for the `nested` mapping datatype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for the
include_in_parentandinclude_in_rootmapping parameters for the
nestedmapping datatype.Closes #52309.