-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL: specify command to run the CLI on a remote machine without Elasticsearch #52626
Conversation
Elasticsearch is not installed
…o 48729_enhancement
Pinging @elastic/es-search (:Search/SQL) |
Pinging @elastic/es-docs (>docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! Left some comments.
-------------------------------------------------- | ||
|
||
The jar name will be different for each Elasticsearch version, thus | ||
the generic `VERSION` specified in the example above. Also, if not running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change Also -> Moreover or Furthermore
the scripts just launch it. You can move it around to other machines | ||
without having to install Elasticsearch on them. Without the already | ||
provided script files, you can use a command similar to the following | ||
to start the SQL CLI. A Java version not earlier than the one used to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't be compiled with Java 13 and run with Java 12 (for earler 7.x versions) ?
-------------------------------------------------- | ||
|
||
The jar name will be different for each Elasticsearch version, thus | ||
the generic `VERSION` specified in the example above. Also, if not running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also provide an example of the version? like 7.5.2
or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@astefan, we might need to remove the |
Small docs improvement by specifying a Java command to run the SQL CLI on a machine where Elasticsearch is not installed on.
Addresses #48729