Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: specify command to run the CLI on a remote machine without Elasticsearch #52626

Merged
merged 4 commits into from
Feb 21, 2020

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Feb 21, 2020

Small docs improvement by specifying a Java command to run the SQL CLI on a machine where Elasticsearch is not installed on.

Addresses #48729

@astefan astefan added >docs General docs changes :Analytics/SQL SQL querying v8.0.0 v7.7.0 labels Feb 21, 2020
@astefan astefan requested review from costin, bpintea and matriv February 21, 2020 09:04
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/SQL)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Left some comments.

--------------------------------------------------

The jar name will be different for each Elasticsearch version, thus
the generic `VERSION` specified in the example above. Also, if not running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change Also -> Moreover or Furthermore

the scripts just launch it. You can move it around to other machines
without having to install Elasticsearch on them. Without the already
provided script files, you can use a command similar to the following
to start the SQL CLI. A Java version not earlier than the one used to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't be compiled with Java 13 and run with Java 12 (for earler 7.x versions) ?

--------------------------------------------------

The jar name will be different for each Elasticsearch version, thus
the generic `VERSION` specified in the example above. Also, if not running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also provide an example of the version? like 7.5.2 or something like that.

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astefan astefan merged commit 477b0ed into elastic:master Feb 21, 2020
@astefan astefan deleted the 48729_enhancement branch February 21, 2020 11:26
astefan added a commit that referenced this pull request Feb 21, 2020
@bpintea
Copy link
Contributor

bpintea commented Feb 24, 2020

@astefan, we might need to remove the ./ in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying >docs General docs changes v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants