Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testSeqNoCollision #52588

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Fix testSeqNoCollision #52588

merged 1 commit into from
Feb 20, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 20, 2020

Adjusts the assertion as we trim translog more eagerly since #52556.

Relates #52556
Closes #52148

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.7.0 labels Feb 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Nhat!

@dnhatn
Copy link
Member Author

dnhatn commented Feb 20, 2020

Thanks Yannick.

@dnhatn dnhatn merged commit d46d931 into elastic:master Feb 20, 2020
@dnhatn dnhatn deleted the fix-seqno-collision branch February 20, 2020 19:29
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 26, 2020
Adjusts the assertion as we trim translog more eagerly since elastic#52556.

Relates elastic#52556
Closes elastic#52148
dnhatn added a commit that referenced this pull request Feb 26, 2020
Adjusts the assertion as we trim translog more eagerly since #52556.

Relates #52556
Closes #52148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Failure in IndexLevelReplicationTests.testSeqNoCollision
4 participants