[ML][Inference] don't return inflated definition when storing trained models #52573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
benwtrent
changed the title
|
Can you add a note to the docs please. Something along the lines
|
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 20, 2020
… models (elastic#52573) When `PUT` is called to store a trained model, it is useful to return the newly create model config. But, it is NOT useful to return the inflated definition. These definitions can be large and returning the inflated definition causes undo work on the server and client side.
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 20, 2020
… models (elastic#52573) When `PUT` is called to store a trained model, it is useful to return the newly create model config. But, it is NOT useful to return the inflated definition. These definitions can be large and returning the inflated definition causes undo work on the server and client side.
benwtrent
added a commit
that referenced
this pull request
Feb 20, 2020
… models (#52573) (#52583) When `PUT` is called to store a trained model, it is useful to return the newly create model config. But, it is NOT useful to return the inflated definition. These definitions can be large and returning the inflated definition causes undo work on the server and client side.
benwtrent
added a commit
that referenced
this pull request
Feb 21, 2020
… models (#52573) (#52580) When `PUT` is called to store a trained model, it is useful to return the newly create model config. But, it is NOT useful to return the inflated definition. These definitions can be large and returning the inflated definition causes undo work on the server and client side. Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
PUTis called to store a trained model, it is useful to return the newly create model config. But, it is NOT useful to return the inflated definition.These definitions can be large and returning the inflated definition causes undo work on the server and client side.