Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FreezeStep retryable #52540

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Conversation

probakowski
Copy link
Contributor

This change marks FreezeStep as retryable and adds test to make sure we can really run it again.

This change marks `FreezeStep` as retryable and adds test to make sure we can really run it again.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, short and sweet :)

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done Przemko

@probakowski probakowski merged commit ba9516e into elastic:master Feb 20, 2020
@probakowski probakowski deleted the freeze-retryable branch February 20, 2020 09:42
probakowski added a commit to probakowski/elasticsearch that referenced this pull request Feb 20, 2020
* Make FreezeStep retryable

This change marks `FreezeStep` as retryable and adds test to make sure we can really run it again.

* refactor tests
probakowski added a commit that referenced this pull request Feb 21, 2020
* Make FreezeStep retryable

This change marks `FreezeStep` as retryable and adds test to make sure we can really run it again.

* refactor tests

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants