Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchronization in ByteSizeCachingDirectory #52512

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Feb 19, 2020

One particular code place was synchronizing on the wrong object.

@ywelsch ywelsch added >bug :Distributed Indexing/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. v8.0.0 v7.7.0 v7.6.1 labels Feb 19, 2020
@ywelsch ywelsch requested a review from jpountz February 19, 2020 12:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Store)

Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, great catch. How did you find it?

@ywelsch
Copy link
Contributor Author

ywelsch commented Feb 19, 2020

Just stumbled upon this while tracing through the code for an unrelated investigation

@ywelsch ywelsch merged commit b176cca into elastic:master Feb 19, 2020
ywelsch added a commit that referenced this pull request Feb 19, 2020
One particular code place was synchronizing on the wrong object.
ywelsch added a commit that referenced this pull request Feb 19, 2020
One particular code place was synchronizing on the wrong object.
sbourke pushed a commit to sbourke/elasticsearch that referenced this pull request Feb 19, 2020
One particular code place was synchronizing on the wrong object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Indexing/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. v7.6.1 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants