Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unit tests for AnomalyDetectorsIndex class #52417

Merged
merged 3 commits into from
Feb 19, 2020

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Feb 17, 2020

This PR adds unit tests for AnomalyDetectorsIndex class.

@przemekwitek przemekwitek added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.0.0 v7.7.0 labels Feb 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek force-pushed the add_missing_unit_tests branch from ca9ff11 to 0c7ffb8 Compare February 19, 2020 09:23
@przemekwitek przemekwitek merged commit a2c1f2d into elastic:master Feb 19, 2020
@przemekwitek przemekwitek deleted the add_missing_unit_tests branch February 19, 2020 10:27
sbourke pushed a commit to sbourke/elasticsearch that referenced this pull request Feb 19, 2020
* Implement unit tests for AnomalyDetectorsIndex class

* Remove unused import

* Apply review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >test Issues or PRs that are addressing/adding tests v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants