Unit tests for Range and DateRange aggs #52380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
|
@elasticmachine run elasticsearch-ci/2 |
nik9000
approved these changes
Feb 18, 2020
| private void testBothResolutions(Query query, | ||
| CheckedConsumer<RandomIndexWriter, IOException> buildIndex, | ||
| Consumer<InternalRange<? extends InternalRange.Bucket, ? extends InternalRange>> verify) | ||
| throws IOException { |
There was a problem hiding this comment.
This line looks like it has kind of funny indentation.
sbourke
pushed a commit
to sbourke/elasticsearch
that referenced
this pull request
Feb 19, 2020
85 tasks
not-napoleon
added a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Mar 30, 2020
not-napoleon
added a commit
that referenced
this pull request
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds a bit more test coverage for things I'm going to be touching in the VS refactor soon.