Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input snapshotting error when using test clusters cliSetup #52340

Merged

Conversation

mark-vieira
Copy link
Contributor

This PR fixes an error when attempting to use the cliSetup configuration option on a test cluster. The root cause was that our LazyPropertyList did not properly handle collection types that were themselves complex types with their own @Input annotations. This PR introduces a getFlatNormalizedCollection() method which allows Gradle's @Nested annotation to work properly.

Example error:

Unable to store input properties for task ':plugins:ingest-attachment:integTestRunner'. Property 'clusters.integTest$0.nodes.$0.cliSetup.$0.value' with value 'org.elasticsearch.gradle.testclusters.ElasticsearchNode$CliEntry@262bda8d' cannot be serialized.
> Could not serialize value of type ElasticsearchNode.CliEntry
  > org.elasticsearch.gradle.testclusters.ElasticsearchNode$CliEntry

@mark-vieira mark-vieira requested a review from rjernst February 13, 2020 21:13
@mark-vieira mark-vieira added the :Delivery/Build Build or test infrastructure label Feb 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

Signed-off-by: Mark Vieira <[email protected]>
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v7.6.1 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants