Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: [Tests] Add tests for fixed issues #52335

Merged
merged 1 commit into from
Feb 14, 2020
Merged

SQL: [Tests] Add tests for fixed issues #52335

merged 1 commit into from
Feb 14, 2020

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Feb 13, 2020

Add tests to verify behaviour for fixed issues:
#33724
#38306

@matriv
SQL: [Tests] Add tests for fixed issues
04cfb75 
Add tests to verify behaviour for
fixed issues: elastic#33724 & elastic#38306
@matriv matriv added >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying v8.0.0 v7.7.0 v7.6.1 labels Feb 13, 2020
@matriv matriv requested review from costin and astefan February 13, 2020 18:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/SQL)

astefan
astefan approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matriv matriv merged commit 89fb675 into elastic:master Feb 14, 2020
@matriv matriv deleted the add-tests branch February 14, 2020 10:22
matriv added a commit that referenced this pull request Feb 14, 2020
@matriv
SQL: [Tests] Add tests for fixed issues (#52335)
51e74be 
Add tests to verify behaviour for
fixed issues: #33724 & #38306

(cherry picked from commit 89fb675)
matriv added a commit that referenced this pull request Feb 14, 2020
@matriv
SQL: [Tests] Add tests for fixed issues (#52335)
fbd011f 
Add tests to verify behaviour for
fixed issues: #33724 & #38306

(cherry picked from commit 89fb675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefan astefan astefan approved these changes

@costin costin Awaiting requested review from costin

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >test Issues or PRs that are addressing/adding tests v7.6.1 v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matriv @elasticmachine @astefan @jakelandis