Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded test PreventFailingBuildIT #52318

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

davidkyle
Copy link
Member

Ironically PreventFailingBuildIT.testSoThatTestsDoNotFail is causing failures as documented in #52197. The test looks like it was added when the other tests in the suite were muted and then forgotten about it can now be removed.

Forward port of #52198

Ironically PreventFailingBuildIT.testSoThatTestsDoNotFail is causing failures
as documented in elastic#52197. The no longer serves a purpose and can now be removed.
@davidkyle davidkyle added >test Issues or PRs that are addressing/adding tests :Data Management/Monitoring v8.0.0 labels Feb 13, 2020
@davidkyle davidkyle requested a review from martijnvg February 13, 2020 13:12
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Monitoring)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle merged commit a6ab7ef into elastic:master Feb 14, 2020
@davidkyle davidkyle deleted the removes-empty-test branch February 14, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Monitoring >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants