Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize naming of fetch subphases. #52171

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Standardize naming of fetch subphases. #52171

merged 1 commit into from
Feb 13, 2020

Conversation

jtibshirani
Copy link
Contributor

This commit makes the names of fetch subphases more consistent:

  • Now the names end in just 'Phase', whereas before some ended in
    'FetchSubPhase' or 'SubPhase'. This matches the query subphases like
    AggregationPhase and SuggestPhase.
  • Some names include 'fetch' like FetchScorePhase to avoid ambiguity about
    their purpose.

@jtibshirani
Standardize naming of fetch subphases.
9ccce46 
This commit makes the names of fetch subphases more consistent:
* Now the names end in just 'Phase', whereas before some ended in
  'FetchSubPhase'. This matches the query subphases like AggregationPhase.
* Some names include 'fetch' like FetchScorePhase to avoid ambiguity about what
  they do.
@jtibshirani jtibshirani added :Search/Search Search-related issues that do not fall into other categories >refactoring v8.0.0 v7.7.0 v7.6.1 labels Feb 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

romseygeek
romseygeek approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtibshirani
Copy link
Contributor Author

Thanks for the review !

@jtibshirani jtibshirani merged commit 067eecb into elastic:master Feb 13, 2020
@jtibshirani jtibshirani deleted the fetch-phases branch February 13, 2020 21:00
jtibshirani added a commit that referenced this pull request Feb 13, 2020
@jtibshirani
Standardize naming of fetch subphases. (#52171)
0d7165a 
This commit makes the names of fetch subphases more consistent:
* Now the names end in just 'Phase', whereas before some ended in
  'FetchSubPhase'. This matches the query subphases like AggregationPhase.
* Some names include 'fetch' like FetchScorePhase to avoid ambiguity about what
  they do.
jtibshirani added a commit that referenced this pull request Feb 13, 2020
@jtibshirani
Standardize naming of fetch subphases. (#52171)
ad01f07 
This commit makes the names of fetch subphases more consistent:
* Now the names end in just 'Phase', whereas before some ended in
  'FetchSubPhase'. This matches the query subphases like AggregationPhase.
* Some names include 'fetch' like FetchScorePhase to avoid ambiguity about what
  they do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees
No one assigned
Labels
>refactoring :Search/Search Search-related issues that do not fall into other categories v7.6.1 v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtibshirani @elasticmachine @romseygeek @jakelandis