-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move docker-compose logging statement to debug #52107
Merged
jasontedor
merged 3 commits into
elastic:master
from
jasontedor:docker-compose-tests-debug-logging
Feb 10, 2020
Merged
Move docker-compose logging statement to debug #52107
jasontedor
merged 3 commits into
elastic:master
from
jasontedor:docker-compose-tests-debug-logging
Feb 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When docker-compose is required for a test fixture but is not available, we warn log a message to this effect. This ends up being noise during configuration, especially when working locally. This commit changes the logging level of these messages to debug.
jasontedor
added
>non-issue
:Delivery/Build
Build or test infrastructure
v8.0.0
v7.7.0
labels
Feb 9, 2020
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer info vs debug, otherwise LGTM.
buildSrc/src/main/java/org/elasticsearch/gradle/testfixtures/TestFixturesPlugin.java
Outdated
Show resolved
Hide resolved
jasontedor
commented
Feb 10, 2020
buildSrc/src/main/java/org/elasticsearch/gradle/testfixtures/TestFixturesPlugin.java
Outdated
Show resolved
Hide resolved
…estFixturesPlugin.java
@elasticmachine update branch |
mark-vieira
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
jasontedor
added a commit
that referenced
this pull request
Feb 10, 2020
When docker-compose is required for a test fixture but is not available, we warn log a message to this effect. This ends up being noise during configuration, especially when working locally. This commit changes the logging level of these messages to debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Delivery/Build
Build or test infrastructure
>non-issue
Team:Delivery
Meta label for Delivery team
v7.7.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When docker-compose is required for a test fixture but is not available, we warn log a message to this effect. This ends up being noise during configuration, especially when working locally. This commit changes the logging level of these messages to debug.