Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILM make the set-single-node-allocation retryable #52077

Merged

Conversation

andreidan
Copy link
Contributor

Closes #43401

@andreidan andreidan added :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.7.0 labels Feb 7, 2020
@andreidan andreidan requested a review from dakrone February 7, 2020 19:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one caveat, needs an extra parameter for the index name in the exception. Thanks Andrei!

logger.debug("could not find any nodes to allocate index [{}] onto prior to shrink");
listener.onResponse(false);
listener.onFailure(new NoNodeAvailableException("could not find any nodes to allocate index [{}] onto prior to shrink"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the index name to fill in the {} in its params

@andreidan
Copy link
Contributor Author

@elasticmachine update branch

@andreidan andreidan merged commit 0e47311 into elastic:master Feb 10, 2020
andreidan added a commit to andreidan/elasticsearch that referenced this pull request Feb 10, 2020
andreidan added a commit that referenced this pull request Feb 14, 2020
@bpintea bpintea added the >bug label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILM Shrink action will not retry allocation in a timely manner if it cannot find a suitable destination node
5 participants