-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILM make the set-single-node-allocation retryable #52077
ILM make the set-single-node-allocation retryable #52077
Conversation
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one caveat, needs an extra parameter for the index name in the exception. Thanks Andrei!
logger.debug("could not find any nodes to allocate index [{}] onto prior to shrink"); | ||
listener.onResponse(false); | ||
listener.onFailure(new NoNodeAvailableException("could not find any nodes to allocate index [{}] onto prior to shrink")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the index name to fill in the {}
in its params
@elasticmachine update branch |
(cherry picked from commit 0e47311) Signed-off-by: Andrei Dan <[email protected]>
(cherry picked from commit 0e47311) Signed-off-by: Andrei Dan <[email protected]>
Closes #43401