Disallow identical dynamic_templates definitions
#52062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the same dynamic_templates can be defined more than once by error in the same mappings file. This most certainly is unintentional and can create issues like those reported in elastic#28988. This change checks for duplicates while parsing and throws an error if we encounter the same definition twice. Closes elastic#28988
cbuescher
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
|
@jtibshirani after your comments on #51817 I marked the original issue for discussion but thought it wouldn't hurt to open this PR as another proposal. I think we can safely disallow definitions that are entirely identical, which we should be able to check at parsing time. The examples given in #29200 (comment) wouldn't be affected by these checks. Let me know what you think... |
|
@elasticmachine update branch |
|
merge conflict between base and head |
|
Thanks @cbuescher, it's nice to know this option is possible. I'll wait to do a detailed review until we discuss #28988. |
This was referenced Mar 10, 2020
|
Superseded by #53326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the same dynamic_templates can be defined more than once by error in
the same mappings file. This most certainly is unintentional and can create
issues like those reported in #28988. This change checks for identical duplicates
while parsing and throws an error if we encounter the same definition twice.
Closes #28988