-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Correct source.index
parm def in reindex API
#52004
Conversation
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-distributed (:Distributed/Reindex) |
_source.index
parm def in reindex APIsource.index
parm def in reindex API
I think we should just support the "," notation instead to try to align with the multiple indices documentation. This is also how snapshot/restore works. |
Opened #52044 to fix this. |
Corrects the `source.index` request body parameter definition to state that arrays, not comma-separated values, are accepted.
Thanks @henningandersen. However, I think this would still be a relevant docs update for I've changed the target branch and updated the labels appropriately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ideally, we should backport the fix from #52044 to 6.8 too, but given that there is such an easy workaround and the code changed a lot between 6.8 and 7.x, I think just updating the docs instead in 6.8 is fine.
I am not sure about 7.5 though, given that 7.6 is now released, I assume we should only do this for 6.8? The next 7.6 release will contain the fix.
Thanks @henningandersen. After taking a closer look at the 6.8 docs, I believe this is already documented pretty well: I'll close this PR. Thanks for fixing this! |
Corrects the
source.index
request body parameter definition tostate that arrays, not comma-separated values, are accepted.
Relates to #51949