Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: [Tests] add tests for literals and GROUP BY #51878

Merged
merged 1 commit into from
Feb 5, 2020
Merged

SQL: [Tests] add tests for literals and GROUP BY #51878

merged 1 commit into from
Feb 5, 2020

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Feb 4, 2020

Add unit and integration tests where literals are SELECTed
in combination with GROUP BY and aggregate functions.

Relates to issues #41411 and #34583
which have been fixed.

@matriv
SQL: [Tests] add tests for literals and GROUP BY
1cf8479 
Add unit and integration tests where literals are SELECTed
in combination with GROUP BY and possibly aggregate functions.

Relates to elastic#41411 and elastic#34583
which have been fixed.
@matriv matriv added >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying v8.0.0 v7.7.0 v7.6.1 labels Feb 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/SQL)

@matriv matriv requested review from costin and removed request for a03nikki February 4, 2020 17:06
@matriv
Copy link
Contributor Author

matriv commented Feb 4, 2020

We could add more integ tests for those cases but I'd rather wait for the community contributor to reform the PR #42121 which contains a bunch of those.

costin
costin approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

astefan
astefan approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matriv matriv merged commit b97f1ca into elastic:master Feb 5, 2020
@matriv matriv deleted the agg-tests branch February 5, 2020 11:32
matriv added a commit that referenced this pull request Feb 5, 2020
@matriv
SQL: [Tests] add tests for literals and GROUP BY (#51878)
64f9a20 
Add unit and integration tests where literals are SELECTed
in combination with GROUP BY and possibly aggregate functions.

Relates to #41411 and #34583
which have been fixed.

(cherry picked from commit b97f1ca)
matriv added a commit that referenced this pull request Feb 5, 2020
@matriv
SQL: [Tests] add tests for literals and GROUP BY (#51878)
36f582a 
Add unit and integration tests where literals are SELECTed
in combination with GROUP BY and possibly aggregate functions.

Relates to #41411 and #34583
which have been fixed.

(cherry picked from commit b97f1ca)
@polyfractal polyfractal added v7.6.0 and removed v7.6.1 labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefan astefan astefan approved these changes

@costin costin costin approved these changes

@bpintea bpintea Awaiting requested review from bpintea

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >test Issues or PRs that are addressing/adding tests v7.6.0 v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matriv @elasticmachine @costin @astefan @jakelandis @polyfractal