Increase disruption test publish timeout to 5s #51803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new mechanism for storing cluster state in lucene, we store index metadata in multiple data paths too. This causes cluster state publish to timeout too frequently with a 1s timeout, so increasing it to 5s. Closes elastic#51329
henningandersen
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
ywelsch
reviewed
Feb 3, 2020
| @@ -128,7 +128,7 @@ protected void beforeIndexDeletion() throws Exception { | |||
| .put(FollowersChecker.FOLLOWER_CHECK_TIMEOUT_SETTING.getKey(), "1s") // for hitting simulated network failures quickly | |||
| .put(FollowersChecker.FOLLOWER_CHECK_RETRY_COUNT_SETTING.getKey(), 1) // for hitting simulated network failures quickly | |||
| .put(JoinHelper.JOIN_TIMEOUT_SETTING.getKey(), "10s") // still long to induce failures but to long so test won't time out | |||
| .put(Coordinator.PUBLISH_TIMEOUT_SETTING.getKey(), "1s") // <-- for hitting simulated network failures quickly | |||
| .put(Coordinator.PUBLISH_TIMEOUT_SETTING.getKey(), "5s") // <-- for hitting simulated network failures quickly | |||
There was a problem hiding this comment.
I think we should do the same for the follower check, which is also racing publication and can depend on writing out state. For full symmetry, perhaps also for leader check.
There was a problem hiding this comment.
Fixed here 3163f62
henningandersen
added a commit
that referenced
this pull request
Feb 3, 2020
With the new mechanism for storing cluster state in lucene, we store index metadata in multiple data paths too. This causes cluster state publish to timeout too frequently with a 1s timeout, so increasing it to 5s. Also increasing follower check timeout to 5s since it also sometimes has fsync in its timeout path and leader check for symmetry. Closes #51329
henningandersen
added a commit
that referenced
this pull request
Feb 3, 2020
With the new mechanism for storing cluster state in lucene, we store index metadata in multiple data paths too. This causes cluster state publish to timeout too frequently with a 1s timeout, so increasing it to 5s. Also increasing follower check timeout to 5s since it also sometimes has fsync in its timeout path and leader check for symmetry. Closes #51329
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Feb 3, 2020
After elastic#51803, the timeouts waiting for assertions around master change were too short.
henningandersen
added a commit
that referenced
this pull request
Feb 3, 2020
After #51803, the timeouts waiting for assertions around master change were too short.
henningandersen
added a commit
that referenced
this pull request
Feb 3, 2020
After #51803, the timeouts waiting for assertions around master change were too short.
henningandersen
added a commit
that referenced
this pull request
Feb 3, 2020
After #51803, the timeouts waiting for assertions around master change were too short.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new mechanism for storing cluster state in lucene, we store
index metadata in multiple data paths too. This causes cluster state
publish to timeout too frequently with a 1s timeout, so increasing it to
5s.
Closes #51329