Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the type for "slices" in the Delete By Query REST API specification #51792

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

karmi
Copy link
Contributor

@karmi karmi commented Feb 2, 2020

The previous patch in c1d9966 incorrectly set the type to number|auto,
which is incorrect — the "polymorphic" type, denoted with the | sign,
should contain only other types, ie. number, string, bool, etc.

Fixes #51535

The previous patch in c1d9966 incorrectly set the `type` to `number|auto`,
which is incorrect — the "polymorphic" type, denoted with the `|` sign,
should contain only other types, ie. number, string, bool, etc
@karmi karmi merged commit 68db7fc into master Feb 2, 2020
@karmi karmi deleted the fix_rest_spec_delete_by_query branch February 2, 2020 17:09
karmi added a commit that referenced this pull request Feb 2, 2020
…on (#51792)

The previous patch in c1d9966 incorrectly set the `type` to `number|auto`,
which is incorrect — the "polymorphic" type, denoted with the `|` sign,
should contain only other types, ie. number, string, bool, etc.

Fixes #51535

(cherry picked from commit 68db7fc)
karmi added a commit that referenced this pull request Feb 2, 2020
…on (#51792) (#51793)

The previous patch in c1d9966 incorrectly set the `type` to `number|auto`,
which is incorrect — the "polymorphic" type, denoted with the `|` sign,
should contain only other types, ie. number, string, bool, etc.

Fixes #51535

(cherry picked from commit 68db7fc)
karmi added a commit that referenced this pull request Feb 5, 2020
… specification

This patch supplements #51792 and #51535 where the type of the "slices" parameter has been fixed.
karmi added a commit that referenced this pull request Feb 5, 2020
… specification (#51908)

This patch supplements #51792 and #51535 where the type of the "slices" parameter has been fixed.
karmi added a commit that referenced this pull request Feb 5, 2020
… specification (#51908)

This patch supplements #51792 and #51535 where the type of the "slices" parameter has been fixed.

(cherry picked from commit 2ed9e95)
karmi added a commit that referenced this pull request Feb 5, 2020
… specification (#51908) (#51911)

This patch supplements #51792 and #51535 where the type of the "slices" parameter has been fixed.

(cherry picked from commit 2ed9e95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant