Disable build cache for packaging tests #51717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Vieira <[email protected]>
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
rjernst
reviewed
Jan 31, 2020
| @@ -137,6 +137,7 @@ processTestResources { | |||
| } | |||
|
|
|||
| task integTest(type: Test) { | |||
| outputs.doNotCacheIf('Build cache is disabled for Docker tests') { true } | |||
There was a problem hiding this comment.
This isn't actually a packaging test, it's running rest tests with docker. I don't think we disable caching for the rest of rest or qa tests do we?
There was a problem hiding this comment.
True it's not a packaging test, but the same applies, we aren't considering the Docker image as an input here.
We don't use the Docker image in any other tests, with the exception of those being added in #51658, which prompted me to look into this. For other rest and qa tests we use test clusters, which handles tracking the node distribution as a proper task input.
mark-vieira
added a commit
that referenced
this pull request
Jan 31, 2020
mark-vieira
added a commit
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For packaging tests, calculating inputs is complicated as the thing we are testing could be an archive (tar/zip), a installer package (deb/rpm) or a Docker image. In our build logic we don't make any attempt to track any of these things as an input to the Java packaging tests so there are times where we might be getting false cache hits for these tests. In practice, this hasn't happened because the build cache has been disabled for our packaging test CI builds, but a) we should enable the cache there, and for all other builds and b) we could get incorrect results when running locally with the cache.