Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #51667

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Fix typo #51667

merged 1 commit into from
Jan 31, 2020

Conversation

muffl0n
Copy link
Contributor

@muffl0n muffl0n commented Jan 30, 2020

elasticsearch-node unsafe-bootstap -> elasticsearch-node unsafe-bootstrap

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

elasticsearch-node unsafe-bootstap -> elasticsearch-node unsafe-bootstrap
@cbuescher cbuescher added the >docs General docs changes label Jan 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @muffl0n, thanks for catching this. I will run some tests, but before we can merge this we need you to sign the contributor license agreement, even for small typo changes like this. I will run our CI tests already so we can merge once you signed. Make sure to use the same email when signing as you used in the commit on Github.

@cbuescher
Copy link
Member

@elasticmachine test this please

@muffl0n
Copy link
Contributor Author

muffl0n commented Jan 31, 2020

"contributor license agreement" signed

@cbuescher cbuescher merged commit 5585192 into elastic:7.5 Jan 31, 2020
@cbuescher
Copy link
Member

@muffl0n thanks, will merge to later branches and master as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants