Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore_missing in CsvProcessor #51600

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

probakowski
Copy link
Contributor

This change fixes inverted logic around ignore_missing in CsvProcessor

This change fixes inverted logic around ignore_missing in CsvProcessor
@probakowski probakowski added >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.6.0 v7.7.0 v7.5.3 labels Jan 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@probakowski
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample-matrix-windows

@probakowski probakowski merged commit 303ad97 into elastic:master Jan 29, 2020
@probakowski probakowski deleted the fix-csv-ignore-missing branch January 29, 2020 12:47
probakowski added a commit to probakowski/elasticsearch that referenced this pull request Jan 29, 2020
This change fixes inverted logic around ignore_missing in CsvProcessor
probakowski added a commit that referenced this pull request Jan 29, 2020
This change fixes inverted logic around ignore_missing in CsvProcessor
probakowski added a commit that referenced this pull request Jan 29, 2020
This change fixes inverted logic around ignore_missing in CsvProcessor
@ywelsch
Copy link
Contributor

ywelsch commented Feb 27, 2020

The backport PR seems to have been merged. I'm therefore removing the backport pending label here. Please shout if this is incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v7.6.0 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants