-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ignore_missing in CsvProcessor #51600
Merged
probakowski
merged 1 commit into
elastic:master
from
probakowski:fix-csv-ignore-missing
Jan 29, 2020
Merged
Fix ignore_missing in CsvProcessor #51600
probakowski
merged 1 commit into
elastic:master
from
probakowski:fix-csv-ignore-missing
Jan 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes inverted logic around ignore_missing in CsvProcessor
probakowski
added
>bug
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
v8.0.0
v7.6.0
v7.7.0
v7.5.3
labels
Jan 29, 2020
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
droberts195
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine run elasticsearch-ci/packaging-sample-matrix-windows |
This was referenced Jan 29, 2020
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Jan 29, 2020
This change fixes inverted logic around ignore_missing in CsvProcessor
probakowski
added a commit
that referenced
this pull request
Jan 29, 2020
probakowski
added a commit
that referenced
this pull request
Jan 29, 2020
This was referenced Feb 3, 2020
The backport PR seems to have been merged. I'm therefore removing the backport pending label here. Please shout if this is incorrect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
v7.6.0
v7.7.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes inverted logic around
ignore_missing
inCsvProcessor