Fix RareClusterStateIT Cancelling Publication too Early #51429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for the cluster to have settled down and have the same accepted version on all nodes before executing and cancelling request so that a slow CS accept on one node doesn't make it fall behind and then get sent the full CS because of the diff-version mismatch, breaking the mechanics of this test. Closes elastic#51308
original-brownbear
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
| @@ -370,11 +376,9 @@ public void testDelayedMappingPropagationOnReplica() throws Exception { | |||
|
|
|||
| // Now make sure the indexing request finishes successfully | |||
| disruption.stopDisrupting(); | |||
| assertBusy(() -> { | |||
There was a problem hiding this comment.
These busy assert made no sense, we're never resending the requests we're asserting on here, all these do is make a failed test run take an extra 10s.
|
Thanks Yannick! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 24, 2020
Wait for the cluster to have settled down and have the same accepted version on all nodes before executing and cancelling request so that a slow CS accept on one node doesn't make it fall behind and then get sent the full CS because of the diff-version mismatch, breaking the mechanics of this test. Closes elastic#51308
original-brownbear
added a commit
that referenced
this pull request
Jan 24, 2020
) Wait for the cluster to have settled down and have the same accepted version on all nodes before executing and cancelling request so that a slow CS accept on one node doesn't make it fall behind and then get sent the full CS because of the diff-version mismatch, breaking the mechanics of this test. Closes #51308
rjernst
pushed a commit
that referenced
this pull request
Feb 20, 2020
Wait for the cluster to have settled down and have the same accepted version on all nodes before executing and cancelling request so that a slow CS accept on one node doesn't make it fall behind and then get sent the full CS because of the diff-version mismatch, breaking the mechanics of this test. Closes #51308
|
I've backported this to 7.6 as well, to address the same failure there (https://gradle-enterprise.elastic.co/s/j7bvgrn7srrie). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the cluster to have settled down and have the same accepted version on all nodes before
executing and cancelling request so that a slow CS accept on one node doesn't make it fall behind
and then get sent the full CS because of the diff-version mismatch, breaking the mechanics of this test.
i.e. avoiding this situation:
Closes #51308